fix(util-endpoints): reject non-ASCII input in substring per Smithy spec#1880
Merged
kuhe merged 2 commits intosmithy-lang:mainfrom Feb 24, 2026
Merged
fix(util-endpoints): reject non-ASCII input in substring per Smithy spec#1880kuhe merged 2 commits intosmithy-lang:mainfrom
kuhe merged 2 commits intosmithy-lang:mainfrom
Conversation
TrevorBurnham
force-pushed
the
handle-non-ascii
branch
from
940be75 to
7fcf15c
Compare
kuhe
reviewed
Feb 24, 2026
kuhe
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #1097
Description of changes:
The
substringfunction in@smithy/util-endpointsdid not reject inputs containing non-ASCII characters, which is required by the Smithy spec:The fix adds a
/[^\u0000-\u007f]/check to the early-return guard, returningnullfor any input outside the ASCII range. Test cases added for\u0080, accented, and CJK characters.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.